x86/speculation/taa: Fix printing of TAA_MSG_SMT on IBRS_ALL CPUs
authorJosh Poimboeuf <jpoimboe@redhat.com>
Thu, 7 Nov 2019 02:26:46 +0000 (20:26 -0600)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 19 Nov 2019 01:43:33 +0000 (01:43 +0000)
commitf96ed6083330f0157cd06954eb15851dcf93b0fa
tree102979031a611da464561be28d295a342f352093
parentdb00ba74aa0408c99b3fa302e149d647e5eae590
x86/speculation/taa: Fix printing of TAA_MSG_SMT on IBRS_ALL CPUs

For new IBRS_ALL CPUs, the Enhanced IBRS check at the beginning of
cpu_bugs_smt_update() causes the function to return early, unintentionally
skipping the MDS and TAA logic.

This is not a problem for MDS, because there appears to be no overlap
between IBRS_ALL and MDS-affected CPUs.  So the MDS mitigation would be
disabled and nothing would need to be done in this function anyway.

But for TAA, the TAA_MSG_SMT string will never get printed on Cascade
Lake and newer.

The check is superfluous anyway: when 'spectre_v2_enabled' is
SPECTRE_V2_IBRS_ENHANCED, 'spectre_v2_user' is always
SPECTRE_V2_USER_NONE, and so the 'spectre_v2_user' switch statement
handles it appropriately by doing nothing.  So just remove the check.

Fixes: 1b42f017415b ("x86/speculation/taa: Add mitigation for TSX Async Abort")
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Tyler Hicks <tyhicks@canonical.com>
Reviewed-by: Borislav Petkov <bp@suse.de>
Gbp-Pq: Topic bugfix/x86/taa
Gbp-Pq: Name 0010-x86-speculation-taa-Fix-printing-of-TAA_MSG_SMT-on-I.patch
arch/x86/kernel/cpu/bugs.c